Increase MOF compile speed

nyanhp commented 1 year ago

Pull Request (PR) description

This PR aims to increase MOF compilation speed by importing only required resources for each node. In my customer's environments this reduced build time by nearly 90%.

This Pull Request (PR) fixes the following issues

None

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

raandree commented 1 year ago

@gaelcolas, can you have a look at this and merge it. Looks good to me and works.

gaelcolas commented 1 year ago

change looks good but please rebase and fix CHANGELOG conflict.

gaelcolas commented 1 year ago

Ah no, there's still a conflict apparently @nyanhp

raandree commented 1 year ago

Where do you see a conflict, @gaelcolas?

gaelcolas commented 1 year ago

Here @raandree

raandree commented 1 year ago

This is funny. When I look at this PR, it explicitly says that there are no conflicts?!?

According to what you see, how many files do have conflicts? @nyanhp, how does it look like on your end?

gaelcolas commented 1 year ago

Yeah it's weird, not too sure what's going on. Let me make another change, and see if that changes in GitHub.

raandree commented 1 year ago

Thanks for looking into this, @gaelcolas.

gaelcolas commented 1 year ago

While I'm still having GitHub issues I'm trying to solve, I've just realised that this change probably breaks compatibility when not using/building RsopCache "first", is that correct?

gaelcolas commented 1 year ago

Ignore me, it's past my bedtime... 👎

SynEdgy / Sampler.DscPipeline