SynEdgy / Sampler.DscPipeline

DSC Pipeline Helpers and tasks for use with Datum
MIT License
9 stars 9 forks source link

Increase MOF compile speed #18

Closed nyanhp closed 1 year ago

nyanhp commented 1 year ago

Pull Request (PR) description

This PR aims to increase MOF compilation speed by importing only required resources for each node. In my customer's environments this reduced build time by nearly 90%.

This Pull Request (PR) fixes the following issues

None

Task list


This change is Reviewable

raandree commented 1 year ago

@gaelcolas, can you have a look at this and merge it. Looks good to me and works.

gaelcolas commented 1 year ago

change looks good but please rebase and fix CHANGELOG conflict.

gaelcolas commented 1 year ago

Ah no, there's still a conflict apparently @nyanhp

raandree commented 1 year ago

Where do you see a conflict, @gaelcolas?

image

gaelcolas commented 1 year ago

image Here @raandree

raandree commented 1 year ago

This is funny. When I look at this PR, it explicitly says that there are no conflicts?!?

image

According to what you see, how many files do have conflicts? @nyanhp, how does it look like on your end?

gaelcolas commented 1 year ago

Yeah it's weird, not too sure what's going on. Let me make another change, and see if that changes in GitHub.

raandree commented 1 year ago

Thanks for looking into this, @gaelcolas.

gaelcolas commented 1 year ago

While I'm still having GitHub issues I'm trying to solve, I've just realised that this change probably breaks compatibility when not using/building RsopCache "first", is that correct?

gaelcolas commented 1 year ago

Ignore me, it's past my bedtime... 👎