SynEdgy / Sampler.DscPipeline

DSC Pipeline Helpers and tasks for use with Datum
MIT License
9 stars 9 forks source link

Redesign of the function `Split-Pipeline` #22

Closed raandree closed 1 year ago

raandree commented 1 year ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Redesign of the function Split-Array. Most of the time it was not working as expected, especially when requesting larger ChunkCounts (see AutomatedLab/AutomatedLab.Common#118).

Task list


This change is Reviewable

gaelcolas commented 1 year ago

please fix the formatting of the function parameters to be in line with the DSC Community. Thanks

raandree commented 1 year ago

This is done already, HQRM tests passed.

Thanks, Raimund

Excuse brevity, sent on the move


From: Gael @.> Sent: Tuesday, March 14, 2023 4:10:59 PM To: SynEdgy/Sampler.DscPipeline @.> Cc: Raimund Andrée [MSFT] @.>; Author @.> Subject: Re: [SynEdgy/Sampler.DscPipeline] Redesign of the function Split-Pipeline (PR #22)

please fix the formatting of the function parameters to be in line with the DSC Community. Thanks

— Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSynEdgy%2FSampler.DscPipeline%2Fpull%2F22%23issuecomment-1468289928&data=05%7C01%7C%7C56415d1f35fd42431a0508db249e51e2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638144034611133586%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XT%2B%2FdFGVqCJsJQtY0qkk%2Bz4Fey05IIuooSOahcpT53g%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWCC6AXUD3HZHTXSYUFTK3W4CDAHANCNFSM6AAAAAAV2RNAXI&data=05%7C01%7C%7C56415d1f35fd42431a0508db249e51e2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638144034611133586%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Bu6gaiTQ6GTMXqpU%2ByIpprPD%2BCKMkt5TR97Xe%2BVAhAo%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

gaelcolas commented 1 year ago

Yeah, looks like our linting is missing some stuff. The previous layout is what I expect for the parameters. image Ta.

raandree commented 1 year ago

Thanks, @gaelcolas, all fixed now.