search

SynapseFI / SynapseNode

Node.js Client Library for SynapseFI REST V3.1 API | https://docs.synapsefi.com
MIT License
13 stars 36 forks source link

Clean up package.json dependencies #53

Open dguo opened 4 years ago

dguo commented 4 years ago

  1. axios appears in devDependencies, peerDependencies, and dependencies. Since it's required at run time, it seems like it only needs to be in dependencies.

  2. lodash is in devDependencies and peerDependencies, but it's required in buildUrls.js, so it seems like it should be in dependencies.

Peer dependencies are best used for plugins.

p-herbert commented 4 years ago

To follow-up with @dguo's comment this causes significant build issues. We had to include lodash in our service's package dependencies for everything to work.