SynapseFI / SynapseNode

Node.js Client Library for SynapseFI REST V3.1 API | https://docs.synapsefi.com
MIT License
13 stars 36 forks source link

Missing await for instantiateUser #66

Open thepipster opened 4 years ago

thepipster commented 4 years ago

There is a missing await around the instantiateUser method in the lib/Client class

thepipster commented 4 years ago

It's an easy fix, I would submit a pull request but I don't have the rights to create a branch. The fix is;

Change;

return instantiateUser({ data, headerObj, client: this });

to

return await instantiateUser({ data, headerObj, client: this });

dguo commented 4 years ago

@thepipster, just FYI, you can fork the repo, create a branch in your fork, and then create a pull request from that branch.

jenstroeger commented 3 years ago

Thanks @dguo, and yes @thepipster please follow the Fork and Pull Request procedure for now.