search

Syncleus / Ferma

An ORM / OGM for the TinkerPop graph stack.
http://syncleus.com/Ferma
Apache License 2.0
136 stars 26 forks source link

Correct Java issues in README.md #18

Closed joshsh closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage     46.26%   46.26%           
  Complexity      191      191           
=========================================
  Files            22       22           
  Lines          1126     1126           
  Branches        204      204           
=========================================
  Hits            521      521           
  Misses          496      496           
  Partials        109      109

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b45c85...ffd0974. Read the comment docs.

freemo commented 7 years ago

@joshsh Hey these changes look great except one problem. You changed the lambda's to older non lambda java syntax. That works but its much more verbose and may turn off some people from using hte API (which was designed with lambda's in mind). Can you change them back to lambdas and I can approve?

joshsh commented 7 years ago

@freemo let me know if this looks OK

freemo commented 7 years ago

@joshsh looks great, thanks a lot.