Closed freemo closed 6 years ago
Merging #29 into master will increase coverage by
26.65%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #29 +/- ##
=============================================
+ Coverage 52.51% 79.16% +26.65%
- Complexity 280 395 +115
=============================================
Files 31 31
Lines 1394 1397 +3
Branches 279 279
=============================================
+ Hits 732 1106 +374
+ Misses 492 116 -376
- Partials 170 175 +5
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...java/com/syncleus/ferma/DelegatingFramedGraph.java | 81.67% <100%> (+31.67%) |
49 <3> (+24) |
:arrow_up: |
...in/java/com/syncleus/ferma/DefaultTraversable.java | 95.83% <100%> (+56.25%) |
21 <0> (+13) |
:arrow_up: |
...s/ferma/typeresolvers/PolymorphicTypeResolver.java | 95.45% <100%> (+22.72%) |
14 <2> (+4) |
:arrow_up: |
...ies/annotation/AbstractAnnotationFrameFactory.java | 90.9% <0%> (+11.36%) |
17% <0%> (+3%) |
:arrow_up: |
.../main/java/com/syncleus/ferma/ReflectionCache.java | 88.88% <0%> (+12.69%) |
18% <0%> (+3%) |
:arrow_up: |
...a/framefactories/annotation/ReflectionUtility.java | 75.72% <0%> (+16.5%) |
48% <0%> (+8%) |
:arrow_up: |
...n/java/com/syncleus/ferma/AbstractVertexFrame.java | 89.89% <0%> (+21.21%) |
41% <0%> (+9%) |
:arrow_up: |
.../java/com/syncleus/ferma/AbstractElementFrame.java | 74.5% <0%> (+23.52%) |
22% <0%> (+6%) |
:arrow_up: |
...amefactories/annotation/PropertyMethodHandler.java | 74.46% <0%> (+25.53%) |
14% <0%> (+6%) |
:arrow_up: |
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 391d2a6...55b639d. Read the comment docs.
@veskoo93 so to get us that final 10% the key will be to use Mockito (might need to add it as a dependency). If you create a mock for the transaction portion that creates dummy values it should be possible rather easily. It will take some care to do it in a way that is useful, so might want to try it out on one or two tests and share it with me so i can help advise on if its a good approach. Just make sure the assertions you make and the way you mock the transactions provide useful tests.
@veskoo93 since we have some critical bug fixes in this PR I'm going to merge in what we have so far. But with my advice above i think we can cover a reasonable portion of what is left. Just continue off the unittests branch and create a new PR when you have more for me to review. If you need help figuring out how to use mockito to cover what is left let me know and I can provide some advice.
@veskoo93 actually since its merged just go off master, ill just delete this branch.
@veskoo93 hey, so i rebased your commits and they are now in a new branch called unittests (this PR is based off of it). If you make any new commits please make sure its from the unittests branch and not the one you've been working on. This one squashes all your commits into one and I cleaned up your commit message. I also added an additional commit of my own to fix the broken unit tests (thanks for catching those).