Syncleus / Ferma

An ORM / OGM for the TinkerPop graph stack.
http://syncleus.com/Ferma
Apache License 2.0
136 stars 26 forks source link

More unit tests and fixes bringing coverage higher. #35

Closed freemo closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #35 into master will increase coverage by 5.9%. The diff coverage is 70.58%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #35     +/-   ##
===========================================
+ Coverage     79.16%   85.07%   +5.9%     
- Complexity      395      453     +58     
===========================================
  Files            31       31             
  Lines          1397     1407     +10     
  Branches        279      283      +4     
===========================================
+ Hits           1106     1197     +91     
+ Misses          116       67     -49     
+ Partials        175      143     -32
Impacted Files Coverage Δ Complexity Δ
...java/com/syncleus/ferma/DelegatingFramedGraph.java 94.73% <100%> (+13.05%) 58 <0> (+9) :arrow_up:
...ain/java/com/syncleus/ferma/AbstractEdgeFrame.java 85.18% <60%> (+18.51%) 13 <0> (+4) :arrow_up:
...n/java/com/syncleus/ferma/AbstractVertexFrame.java 94.11% <60%> (+4.21%) 45 <0> (+4) :arrow_up:
...ies/annotation/AbstractAnnotationFrameFactory.java 95.65% <75%> (+4.74%) 20 <0> (+3) :arrow_up:
...amefactories/annotation/PropertyMethodHandler.java 80.85% <0%> (+6.38%) 15% <0%> (+1%) :arrow_up:
...a/framefactories/annotation/ReflectionUtility.java 88.34% <0%> (+12.62%) 61% <0%> (+13%) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e696c11...124c0a8. Read the comment docs.

freemo commented 7 years ago

@veskoo93 So i squashed your commits, added an additional commit fixing some of your tests, and a third commit fixing bugs you caught. You brought up line coverage by 6% but branch coverage by 10%. So your branch coverage is at 89.70% which I will count as your 90% goal. Amazing job, Ill pay you the bounty immediately.