search

Syncleus / Ferma

An ORM / OGM for the TinkerPop graph stack.
http://syncleus.com/Ferma
Apache License 2.0
136 stars 26 forks source link

Support pluggable classloaders for AnnotationFrameFactory #39

Open jsight opened 6 years ago

jsight commented 6 years ago

Right now, this relies on the context classloader, but I would like to provide my own implementation for use by ByteBuddy.

freemo commented 6 years ago

Sure. Feel free to submit a pull request with your ideas and I'll review it.

On Jan 2, 2018 6:25 PM, "Jesse Sightler" notifications@github.com wrote:

Right now, this relies on the context classloader, but I would like to provide my own implementation for use by ByteBuddy.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Syncleus/Ferma/issues/39, or mute the thread https://github.com/notifications/unsubscribe-auth/AC5JAo9yiDBXzI-pagPjoIWxAMq2C1C_ks5tGrrLgaJpZM4RRMfu .

ghost commented 6 years ago

If I can help you I'll do it just let me know ✋ @jsight

jsight commented 6 years ago

I can try to put together a PR with a few things like this that I have run into. I am currently working on migrating https://github.com/windup/windup to Ferma from Tinkerpop 2 and a forked version of frames.

freemo commented 6 years ago

@jsight Any reason your using a forked version of frames rather than Ferma? I tried to make Ferma very close to Frames for compatibility reasons.

I can obviously help with the PR if anyone needs it. If no one gets to it ill try to add it myself when I have time. Very much appreciate all the help.

jsight commented 6 years ago

https://github.com/Syncleus/Ferma/pull/42

We used a forked version of Frames because we had started with Frames before Ferma existed. We also use a lot of really esoteric functionality for various historical reasons.