Closed jsight closed 6 years ago
Merging #40 into master will decrease coverage by
0.14%
. The diff coverage is75%
.
@@ Coverage Diff @@
## master #40 +/- ##
============================================
- Coverage 84.86% 84.71% -0.15%
Complexity 452 452
============================================
Files 31 31
Lines 1407 1407
Branches 283 286 +3
============================================
- Hits 1194 1192 -2
Misses 70 70
- Partials 143 145 +2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
...mefactories/annotation/AdjacencyMethodHandler.java | 77.21% <75%> (-0.54%) |
47 <0> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3fc3931...480a517. Read the comment docs.
@jsight Would it be possible to add a simple unit test for this please?
@freemo - Yes, definitely. I have run into a few other little issues while porting, so I will add some PRs for those as well.
Thanks so much
On Mon, Jan 8, 2018 at 12:10 PM Jesse Sightler notifications@github.com wrote:
@freemo https://github.com/freemo - Yes, definitely. I have run into a few other little issues while porting, so I will add some PRs for those as well.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Syncleus/Ferma/pull/40#issuecomment-356029952, or mute the thread https://github.com/notifications/unsubscribe-auth/AWNYbxCPdYs96tIk1YY_WeHwsFgC8Amgks5tIkwLgaJpZM4RTi3E .
@jsight approved, sorry for delay
Great, thanks!
On Tue, Jan 16, 2018 at 6:36 PM, Jeffrey Phillips Freeman < notifications@github.com> wrote:
Merged #40 https://github.com/Syncleus/Ferma/pull/40.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Syncleus/Ferma/pull/40#event-1427269448, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIHbYXzxT9sQGQ_jUHQ4gjQVZPK0k1zks5tLTJjgaJpZM4RTi3E .
This simply unlinks the vertex in the case where the passed in vertex is null. This is similar to the frames behavior.