search

Syncleus / Ferma

An ORM / OGM for the TinkerPop graph stack.
http://syncleus.com/Ferma
Apache License 2.0
137 stars 26 forks source link

Allow the user to specify a non-default classloader for the annotation frame factory #42

Open jsight opened 6 years ago

jsight commented 6 years ago

This is really still not sufficient for our use case, as we also rely on the typemanager being able to return multiple interface classes.

I wonder if that is something that we could integrate into upstream later on? Perhaps we can talk about it more?

codecov[bot] commented 6 years ago

Codecov Report

Merging #42 into master will decrease coverage by 0.08%. The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #42      +/-   ##
============================================
- Coverage     84.86%   84.77%   -0.09%     
- Complexity      452      453       +1     
============================================
  Files            31       31              
  Lines          1407     1412       +5     
  Branches        283      283              
============================================
+ Hits           1194     1197       +3     
- Misses           70       72       +2     
  Partials        143      143
Impacted Files Coverage Δ Complexity Δ
...mefactories/annotation/AnnotationFrameFactory.java 70% <0%> (-7.78%) 2 <0> (ø)
...ies/annotation/AbstractAnnotationFrameFactory.java 97.95% <100%> (+0.13%) 22 <1> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3fc3931...2fa89b6. Read the comment docs.

freemo commented 6 years ago

@jsight Hey, things calmed down here and im going through your PR. Can you stop by gitter so we can chat about your use case before I make a decision on merging?

jsight commented 6 years ago

I will do that as soon as possible.

On Tue, Jan 16, 2018 at 6:39 PM, Jeffrey Phillips Freeman < notifications@github.com> wrote:

@jsight https://github.com/jsight Hey, things calmed down here and im going through your PR. Can you stop by gitter so we can chat about your use case before I make a decision on merging?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Syncleus/Ferma/pull/42#issuecomment-358144804, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIHbR3PtcckEMRTYCGfV9pmQthmUn8Yks5tLTM6gaJpZM4RWw1Y .