search

Syncleus / Ferma

An ORM / OGM for the TinkerPop graph stack.
http://syncleus.com/Ferma
Apache License 2.0
137 stars 26 forks source link

Adding better support for untyped edge creation. #5

Closed mohataher closed 7 years ago

mohataher commented 9 years ago

Instead of returning just plain untyped edge, I framed it to the return type of the calling method.

return thiz.getGraph().addFramedEdge(newVertex, thiz, label, method.getReturnType()); Instead of return thiz.getGraph().addFramedEdge(newVertex, thiz, label);

For diving deeper into details, please view thread here http://bugs.syncleus.com/browse/FMA-67

freemo commented 9 years ago

@mohataher Thanks so much, I will review this further. Please keep in mind while GitHub pull requests are totally valid way of submitting patches, our official method is through gerrit and will often get you much quicker turn-over time on my part. For more information see: http://wiki.syncleus.com/index.php/Ferma:Contributing

freemo commented 9 years ago

@mohataher Very first thing I noticed is that this pull request has several undesired files int he commit, things like .classpath and .settings. Please add these to gitignore and remove them from the commits (simply making a new commit that deletes them wont be enough you will have to rebase, since removing them in a new commit would still get them into our history).

freemo commented 9 years ago

@mohataher Also don't forget to add yourself as a contributor (CONTRIBUTORS.md and the pom.xml both have places for this).

mohataher commented 9 years ago

Alright. I will try my best using gerrit next times.

All files removed in the last commit. It's strange how they were pushed even though they were in the gitignore.

Magically (mostly thanks to you), my name was in contributors and pom.xml. I updated it as well.

freemo commented 9 years ago

@mohataher Just noticed this pull request was still outstanding. did we resolve this through a different branch or something?

freemo commented 7 years ago

@mohataher we've implemented this through other means. so going to close this but thanks for your contribution. I've gone ahead and updated your change int he contributors file however.