search

Syncleus / aparapi

The New Official Aparapi: a framework for executing native Java and Scala code on the GPU.
http://aparapi.com
Apache License 2.0
465 stars 59 forks source link

device module unit tests #128

Open yana2301 opened 6 years ago

freemo commented 6 years ago

I've added @CoreRasurae as a reviewer so he can also contribute any comments as this PR develops.

CoreRasurae commented 6 years ago

@yana2301 Hi Yana, I've seen you've removed some integration tests that seem relevant to me... I know they aren't unit tests, but still, integration tests are also useful. Is there a special reason for this removal?

freemo commented 6 years ago

@yana2301 I agree with @CoreRasurae . Several tests were removed that were working well.

CoreRasurae commented 6 years ago

@yana2301 Hi Iana, please tell me when you have this PR ready for reviewing. I will also want to know your plans regarding the deleted tests.