Closed eklavya closed 6 years ago
Merging #133 into master will decrease coverage by
0.58%
. The diff coverage is58.23%
.
@@ Coverage Diff @@
## master #133 +/- ##
============================================
- Coverage 46.86% 46.27% -0.59%
+ Complexity 912 891 -21
============================================
Files 60 60
Lines 9837 9865 +28
Branches 1607 1607
============================================
- Hits 4610 4565 -45
- Misses 4762 4838 +76
+ Partials 465 462 -3
@eklavya approved, good for me to merge?
Maybe BCEL could be shaded to not interfere with the user setup.
Yeah we could use 'jarjar' or something to change the package name, and then include it in aparapi.jar https://github.com/google/jarjar
yea im fine with that, though I'd like to actually see the issue crop up before trying to solve it, if for no other reason than to test that the solution works when it does.
On Wed, Apr 15, 2020 at 9:17 AM grfrost notifications@github.com wrote:
Yeah we could use 'jarjar' or something to change the package name, and then include it in aparapi.jar https://github.com/google/jarjar
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Syncleus/aparapi/pull/133#issuecomment-614034354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXESAQB6UBLN4A4EPDBUPTRMWXWBANCNFSM4FGYCDCA .
Here is an attempt to use Apache BCEL as the jvm bytecode parser.
I need all the help here. Any help in advancing this faster is much appreciated.
Apologies in advance for any nonsense in the code :)