search

Syncplay / syncplay

Client/server to synchronize media playback on mpv/VLC/MPC-HC/MPC-BE on many computers
http://syncplay.pl/
Apache License 2.0
2.1k stars 214 forks source link

Bundle MPV with the mac OS X release #154

Closed FSMaxB closed 6 years ago

FSMaxB commented 6 years ago

I've been trying to use syncplay with a mac user, but she struggled to install MPV and almost gave up on it.

It would be nice if you could bundle mpv with the release so there is only one thing to download and install.

albertosottile commented 6 years ago

There are mpv (official) compiled and bundled .app files available here: https://laboratory.stolendata.net/~djinn/mpv_osx/mpv-latest.tar.gz

FSMaxB commented 6 years ago

I know. But not bundled with Syncplay.

albertosottile commented 6 years ago

Bundling a full version of mpv in Syncplay is not possible because of license issues (some parts are under GPL). Even so, players are updated much more often than Syncplay, and for good reasons. Hence, I do not think that is a good approach to include players in our release cycle.

FSMaxB commented 6 years ago

What is syncplay's license?

Also I mean just putting MPV in the DMG-file, so it can be dragged into the application directory. That wouldn't violate the GPL in any way.

I get the concerns about the updates though, since a video file can very well be crafted in a way that it exploits flaws in C-Code to get code execution. Therefore something like a media player should be kept up to date.

albertosottile commented 6 years ago

Syncplay is under Apache 2.0. Maybe just including the mpv.app would not violate GPL, but again, it does not seem the right approach to me.

Also, I do not see why macOS should be different than Windows in this case. Maybe we could put links to download updated bundled version of the supported players somewhere in the .dmg or in the (upcoming) readme file.

FSMaxB commented 6 years ago

It would be great to have a weblink to the mpv and/or VLC download sites then. (I think it should be possible to create a link as a file).

albertosottile commented 6 years ago

Closed. I added the links on macOS as per PR #156 .