Syncplay / syncplay

Client/server to synchronize media playback on mpv/VLC/MPC-HC/MPC-BE on many computers
http://syncplay.pl/
Apache License 2.0
2.1k stars 214 forks source link

Support for MPC-BE #158

Closed notAutomne closed 6 years ago

notAutomne commented 6 years ago

Hello,

I use MPC-BE (Like MPC-HE, but with black UI and some improvements..)

It seems to not be usable. Can you add support, thanks

Exe name: mpc-be64.exe

Et0h commented 6 years ago

We have looked into this before and it turned out that because MPC-BE did not support the latest version of the MPC-HC API there was nothing we could do from within Syncplay to support it. As such, you should be asking MPC-BE to support Syncplay rather than asking Syncplay to support MPC-BE. If MPC-BE ever supports the current MPC-HC API (i.e. the features which Uriziel added to MPC-HC back in 2012) then we'd love for someone to let us know because then we could just tweak our MPC-HC code to support MPC-BE.

notAutomne commented 6 years ago

Thanks for your reply.

Here the API of MPC-BE (from the official SVN): http://svn.code.sf.net/p/mpcbe/code/tags/release_1.5.1/src/apps/mplayerc/mpcapi.h

Et0h commented 6 years ago

Missing from MPC-BE 1.5.1 API:

It also seems like they haven't fixed the bug which prevents 32-bit applications from working with the 64-bit version, which is to add " : unsigned int" after "typedef enum MPCAPI_COMMAND" (MPC-HC ticket #2470)

For a full list of differences see: https://www.diffnow.com/?report=la7xp

v0lt commented 6 years ago

Try MPC-BE 1.5.2.3123 or later.

Et0h commented 6 years ago

Thanks @v0lt for https://sourceforge.net/p/mpcbe/code/3116/ and https://sourceforge.net/p/mpcbe/code/3119/

Seems to work on a cursory test with MPC-BE 1.5.2.3148 x64, but haven't done a thorough test. If you are using MPC-BE 1.5.2.3123 or above then please copy mpc-be64.exe and rename it mpc-hc64.exe (or mpc-be.exe and rename it mpc-hc.exe), set that as the path to player executable in Syncplay 1.5.0, and tell me how well it works. If we can confirm it works without issue then we can add recognition of the MPC-BE executable filenames to Syncplay. If there are issues we can see if they can be resolved Syncplay-side or if they need further changes to MPC-BE.

@joeoe asked about MPC-BE support back in 2015 (#68) so they might be able to test it too.

Et0h commented 6 years ago

Syncplay with MPC-BE support test build available from http://syncplay.pl/syncplay_v1.5.0_mpcbe.zip - please test it and let me know how it works.

notAutomne commented 6 years ago

Hello,

It seems to work fine, no apparent lags, every functions seems to work fine.

Thanks bro

Et0h commented 6 years ago

@marwanpro Thanks for testing it. I've not had any problems with it either so it seems good to include in the next release of Syncplay.

Et0h commented 6 years ago

MPC-BE support is now in Syncplay 1.5.1: http://syncplay.pl/syncplay-1-5-1/