Feature request: Room history mechanism

Gbd199 commented 4 years ago

Provide a dropdown list with the names of previous rooms. Requires configuration parsing changes/additions and gui logic enhancement.

Gbd199 commented 4 years ago

Opened a pull request #337

Gbd199 commented 4 years ago

Reopening for notice and feedback

Gbd199 commented 4 years ago

@Et0h Can you please take a look and share your thoughts?

Et0h commented 4 years ago

I've posted my thoughts to #337 and the discussion can continue there.

Et0h commented 4 years ago

Okay, so I've accepted #337 and tweaked it with 3c7ca9706d7dfb00d7e1a84ebae7a534d54d42b9

Some things to note about changed from #337 (and a few requests for feedback):

For now I've made it so that you have to manually add rooms to the room list. There could be an optional in the future to allow for rooms to be automatically added, but it would then add complexity to the GUI so it might be fine just leaving it as manual.
I've renamed it 'room list' rather than 'room history' as it is a user-editable list, not just a history.
I've added the combo box to the main GUI and added the option to change the room list to the 'window' portion of the menu bar. I didn't add it to the main GUI because I didn't want to add too many options there (as it). However, I could add a "Show edit room button" option to the Window menu (off by default) if people wanted, in line with what I do for playback controls and auto-play buttons. Thoughts/opinions?
I've moved the edit button in the config window to the right to be more in line with normal UI conventions (even if it is less space efficient).
For now I've not changed it to automatically change the default room to the last one you joined as I'm not sure if that's the behaviour most people want. Thoughts/opinions?

Et0h commented 4 years ago

Changes in 92d2d580f9b6cb8085be9be46b5368a288d0e302:

Room names are now saved by default, this is changeable in the "Add rooms you join to the room" list option in "Misc". I was thinking that it could be the same option for if we have an option in the future to save server addresses automatically.
When you create a managed room, it also now saves the version of the room name which includes the room password.
Room names are now listed alphabetically. Previous behaviour was to have the most recently joined rooms at the top.

Happy for feedback on these changes and if there are any other issues that need to be resolved.

Et0h commented 3 years ago

As this feature has now been introduced in Syncplay 1.6.6 I will close this issue. Thanks to everyone who has contributed!

Gbd199 commented 3 years ago

Very welcomed changes and decisions. Thanks a lot for advancing the issue @Et0h! Awesome to see the mechanism in an official version

Syncplay / syncplay