Syncplay / syncplay

Client/server to synchronize media playback on mpv/VLC/MPC-HC/MPC-BE on many computers
http://syncplay.pl/
Apache License 2.0
2.09k stars 213 forks source link

Can't compile a proper Syncplay.exe #51

Closed wiiaboo closed 9 years ago

wiiaboo commented 9 years ago

Trying to compile 'areYouReady' branch to try the new features, but can't seem to be able to run Syncplay.exe. syncplayClient.py runs fine. Using Python 2.7 Win32.

Output of pip2 freeze: https://gist.github.com/6e0db74ada4650542e52 Output of python buildPy2exe.py: https://gist.github.com/4f6c467d6fe9c6bbb450

syncplay.log:

Traceback (most recent call last):
  File "syncplayClient.py", line 19, in <module>
  File "syncplay\clientManager.pyo", line 7, in run
  File "syncplay\ui\ConfigurationGetter.pyo", line 387, in getConfiguration
  File "syncplay\vendor\qt4reactor.pyo", line 41, in <module>
ImportError: No module named zope.interface

From the official installer file list, I noticed I'm missing two .pyd, "zope.interface._zope_interface_coptimizations.pyd" and "twisted.python._initgroups.pyd".

Uriziel commented 9 years ago

http://superuser.com/questions/124437/how-to-install-zope-on-windows

wiiaboo commented 9 years ago

That tells me nothing. I do have both twisted and zope.interface installed as you can see from pip freeze.

Uriziel commented 9 years ago

Zope's egg doesn't create init.py in one of it's folders.

I was pretty sure the previous link would contain that info, but it didn't, my bad.

Following this link: http://stackoverflow.com/a/11632115/1891329 Specifically, add an empty __init__.py file to the PYTHONDIR/Lib/site-packages/zope directory.

wiiaboo commented 9 years ago

Awesome, that fixed it. Thanks.

Et0h commented 9 years ago

I've now added a note about this issue to the top of the file (https://github.com/Uriziel/syncplay/commit/3e6316e960f735150110e9ae2a3ab5dabedbaf60) and released an official installer with the areYouReady changes (and some bugfixes) as Syncplay 1.3.0 Beta 2. It'd be good to hear what your thoughts are on the new features (and if you find any bugs).

wiiaboo commented 9 years ago

Would be cool if "Autoplay when everyone is ready" saved its state. No bugs so far.

Et0h commented 9 years ago

Do you mean save state when you close and re-open Syncplay (where you might be under different circumstances and might not want to autplay), or are you wanting it to not uncheck the feature when someone leaves (which is behaviour implemented to prevent clashes with the "Pause on leave" feature)?

It is already the case that if you press play when you are ready or everyone else is ready it will unpause, and otherwise it will just set you to ready (so you press play twice to unpause if others aren't ready), so people can just press play as a simple "unpause when everyone is ready" feature.

wiiaboo commented 9 years ago

I mean when closing and re-opening Syncplay. At least in my installation it doesn't remember that setting. I didn't remove configurations when upgrading.

Et0h commented 9 years ago

If you're talking about the checked/unchecked state of the button (rather than whether it is visible) then it isn't currently designed to keep that state. I can ask around to see what people think about it being persistent, although it would be forgotten if someone left a room in any case (to avoid conflict with the 'unpause when user leaves' feature). Long-term persistence could be confusing if it kept its state between different viewing sessions. If everyone is on then people should just press 'play' to show they are ready, and in that case if everyone is ready it will unpause (which is especially useful where people have their media windows full-screened on a single-monitor system, as then they don't have to switch from Syncplay). If it were persistent then ideally it would want to also not uncheck if someone left, which for consistent behaviour would probably want some sort of "minimum people in room to unpause" sub-option (adding to the complexity of the feature).

Et0h commented 9 years ago

wiiaboo: Things have moved over to the main branch now. I've had a go add persistent auto-play, and coupled it with a minimum number of people requirement. Please let me know what you think / if it works.

wiiaboo commented 9 years ago

Ok, I'll try. I've seen a couple of bugs, but they're kinda hard to describe and reproduce. Kinda hard without a second pc. I'll set up a vm.

On Mon, 2 Feb 2015 02:19 Etoh notifications@github.com wrote:

wiiaboo: Things have moved over to the main branch now. I've had a go add persistent auto-play, and coupled it with a minimum number of people requirement. Please let me know what you think / if it works.

— Reply to this email directly or view it on GitHub https://github.com/Uriziel/syncplay/issues/51#issuecomment-72398539.

wiiaboo commented 9 years ago

Works fine so far. No bugs whatsoever.