search

Syncplay / syncplay

Client/server to synchronize media playback on mpv/VLC/MPC-HC/MPC-BE on many computers
http://syncplay.pl/
Apache License 2.0
2.09k stars 213 forks source link

Use --force-window and --idle=once with mpv #53

Closed wiiaboo closed 9 years ago

wiiaboo commented 9 years ago

Allows Syncplay to open mpv without having a media file ready:

Uriziel commented 9 years ago

This is cool.

Et0h commented 9 years ago

Nice one. I'll look into that when I am next free. The important question is the version when the features were added to mpv so Syncplay knows when to use the functionality.

wiiaboo commented 9 years ago

--force-window in 0.2.0, --idle=once hasn't been applied to 0.7.3, I think? but --idle has been there since mplayer, so the safest way to use would be --idle=yes, I guess. At least until 0.8.0 gets released.

Et0h commented 9 years ago

Thanks for the intel. We try to maintain backwards compatibility within Syncplay so this kind of information is rather useful. Using newer functionality is fine so long as there is graceful fallback.

wiiaboo commented 9 years ago

Just --idle seems to work too, so it's probably safe to use that.

Et0h commented 9 years ago

Try https://github.com/Uriziel/syncplay/commit/a795acae0a2e8b19e50e0dfad34acbbeb17be585 and let me know if it works or if it causes any problems.

wiiaboo commented 9 years ago

Seems to be working fine. I'll try a few episodes with friends tomorrow.

Et0h commented 9 years ago

Cheers. Quick fix to a bug introduced by the previous commit: https://github.com/Uriziel/syncplay/commit/fd6d15790a93c3089b914c84e27a677951cecfa7

wiiaboo commented 9 years ago

No bugs so far. I think it's safe to close this?

Et0h commented 9 years ago

Yup, all seems good. Thanks for your contribution :)