search

Syncplay / syncplay

Client/server to synchronize media playback on mpv/VLC/MPC-HC/MPC-BE on many computers
http://syncplay.pl/
Apache License 2.0
2.11k stars 214 forks source link

IINA unpauses on media load #566

Open Lann094 opened 1 year ago

Lann094 commented 1 year ago

Not entirely sure if this should be raised here or with IINA. But despite being based on mpv, media unpauses when it is loaded via Syncplay. I've verified mpv doesn't unpause on load on the same system, and the IINA setting of pause on media load isn't being respected. Adding media via the player window rather than Syncplay does respect this option, and remains paused.

I've had trouble triggering iina-cli and preventing it from playing media, but would love to hear if anyone has any ideas on how this could be pulled off.

Et0h commented 1 year ago

Is the issue resolved by setting pause=yes and reset-on-next-file=pause in your mpv.conf config file for IINA? Does that create new issues of it pausing when it shouldn't be changing pausing?

Lann094 commented 1 year ago

No effect after adding those flags to config. Digging further into logs, I can see pause=yes appears to be getting set regardless, but I'm not particularly well-versed in mpv. Also just attempted no-resume-playback to no avail.

Et0h commented 1 year ago

Unfortunately I don't have a mac so can't investigate this. I'm not sure if this is an issue that can be fixed on the Syncplay side or if it is something that requires changes to IINA. This might relate to https://github.com/iina/iina/issues/3839 and https://github.com/iina/iina/issues/1974

yonkoma commented 1 year ago

I think this is mpv (but not IINA) maintaining pause state when switching files

Et0h commented 1 year ago

Someone who experiences this problem could make an issue at https://github.com/iina/iina and explain the problem and link to the issue to see if anyone from the IINA team wishes to either modify their software to avoid the issue or propose a fix on Syncplay's side to avoid it.

yonkoma commented 1 year ago

I've been testing a rough change to IINA which seems to be working well, I'm going to try to clean it up and make a PR soon.

Et0h commented 1 year ago

I've been testing a rough change to IINA which seems to be working well, I'm going to try to clean it up and make a PR soon.

How's progress on this @yonkoma?

sakronos commented 1 year ago

I've been testing a rough change to IINA which seems to be working well, I'm going to try to clean it up and make a PR soon.

Hi @yonkoma ,

Could you provide a concise explanation of the change? Thank you beforehand.