search

Syncplay / syncplay

Client/server to synchronize media playback on mpv/VLC/MPC-HC/MPC-BE on many computers
http://syncplay.pl/
Apache License 2.0
2.12k stars 215 forks source link

Adjust QSplitter style #689

Closed luk1337 closed 6 days ago

luk1337 commented 2 months ago

This looks much better when using PySide6 6.7.2.

luk1337 commented 2 months ago

Before: Screenshot_20240715_180447

After: Screenshot_20240715_180439

luk1337 commented 2 months ago

I guess it'd be great if someone could test pyside2 and other platforms.

Et0h commented 2 months ago

Tried on Windows 10 dark mode, and the difference is that the old version had a clear grab indicator for the horizontal splitter but the new version does not (both have a grab indicator for the vertical handle). I didn't see any difference for the light mode (where there are no vertical/horizontal grab bars in any case).

Old and new grab bar Syncplay

I wouldn't say having horizontal but not vertical grab bars on Windows 10 dark mode is an improvement, as it means the way it displays it is inconsistent between horizontal and vertical. I might not even notice if I wasn't paying attention, but making an explicit change which is a downgrade on Windows doesn't seem like an improvement. I don't know what OS and theme you are using where it works better for you, but it might also be the case that it looks worse in other circumstances as well.

luk1337 commented 2 months ago

Tried on Windows 10 dark mode, and the difference is that the old version had a clear grab indicator for the horizontal splitter but the new version does not (both have a grab indicator for the vertical handle). I didn't see any difference for the light mode (where there are no vertical/horizontal grab bars in any case). Old and new grab bar Syncplay

I wouldn't say having horizontal but not vertical grab bars on Windows 10 dark mode is an improvement, as it means the way it displays it is inconsistent between horizontal and vertical. I might not even notice if I wasn't paying attention, but making an explicit change which is a downgrade on Windows doesn't seem like an improvement. I don't know what OS and theme you are using where it works better for you, but it might also be the case that it looks worse in other circumstances as well.

hmm, I tried Window 10 in light mode and there was no indicator, so I just killed it. But if dark mode somehow has it, I guess I'll maybe try to look into where it comes from.

luk1337 commented 2 months ago

What about current diff? It looks like this on my system:

image

luk1337 commented 2 months ago

And looks like this without custom handle width: image

Et0h commented 2 months ago

The new version looks fine to me on Windows 10 Dark Mode now, and it now has the resize bars in Windows 10 Light Mode which I would consider an improvement.

daniel-123 commented 2 months ago

Over here with pySide2 it seems to look exactly the same as originally.