search

Syndica / sig

a Solana validator client implementation written in Zig
https://syndica.io/sig
Apache License 2.0
219 stars 34 forks source link

feat(ci) add line size checking to the CI #360

Closed Rexicon226 closed 2 weeks ago

Rexicon226 commented 2 weeks ago

closes #359

My idea with the exclude list is that we'll slowly take files off of it as time goes on. Currently, there are 343 lines in violation left after the current changes. I'll get through the rest of them in a follow-up PR.

Also, excuse the Graphite thing, I was just curious to see what it'd look like. Maybe this could be thought of as a micro-stack lol, where I implement the base feature as one stack, and fix up the lines as a second 🤔 .

I don't think there's much point in going through Graphite right now unless the PR is a much larger feature set than this small tidying PR.

Rexicon226 commented 2 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Rexicon226 and the rest of your teammates on Graphite Graphite

0xNineteen commented 2 weeks ago

if we add this to CI, wont we need to fix all of the line lengths so that CI will pass on main (otherwise it will fail and we wont be able to merge anything?)

Rexicon226 commented 2 weeks ago

if we add this to CI, wont we need to fix all of the line lengths so that CI will pass on main (otherwise it will fail and we wont be able to merge anything?)

no, see the exclude list. i don't think it's reasonable to move everything in one go, I'll slowly be moving files over to the new style.