search

SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
17 stars 21 forks source link

cd_to_working_dir() to get_working_dir #121

Open ashgillman opened 3 years ago

ashgillman commented 3 years ago

To be honest, I do not see the added value of the function cd_to_working_dir as it's use is just to change directory to a directory where the user will store temporary working data. It does it in a totally opaque way and it really just wraps os.path.join + os.makedirs, we might as well just use those in the notebooks and will not have the problem.

Also the user does not seem to know where this directory is, unless he/she reads the docstring. https://github.com/SyneRBI/SIRF-Exercises/blob/ec421f70af805da88e63fc7312c5879c4361a0ea/lib/sirf_exercises/__init__.py#L48

Originally posted by @paskino in https://github.com/SyneRBI/SIRF-Exercises/issues/118#issuecomment-866279905

ashgillman commented 3 years ago

Do we want to replace all to:

os.chdir(get_working_dir())

?

KrisThielemans commented 3 years ago

at this point in time, I wouldn't do it anymore. We can do it afterwards