search

SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
18 stars 21 forks source link

Fix #116 Always create $DATA_PATH #126

Closed ashgillman closed 3 years ago

ashgillman commented 3 years ago

In case no datasets were downloaded, we still need the path for Notebooks.

ashgillman commented 3 years ago

@paskino, this overwrites some of your recent changes. Do you see any issues with WORKING_DIR?

KrisThielemans commented 3 years ago

looks good to me. did you test if the mkdir -p doesn't complain too loudly when it wants to create it in a read-only location?

ashgillman commented 3 years ago

It will still crash if the location doesn't exist, but will be happy if it exists, even if we don't have permission. I think this is the desired behaviour