search

SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
18 stars 21 forks source link

Fix #105 - Untested! #132

Closed ashgillman closed 3 years ago

ashgillman commented 3 years ago

OSX has md5, not md5sum. Unable to test Mac part.

Tested on Ubuntu:

ashgillman commented 3 years ago

@DANAJK , are you able to check?

KrisThielemans commented 3 years ago

@robbietuk maybe you could test this? Just clone this repo, go to PR and scripts/download_data.sh -m -p

DANAJK commented 3 years ago

Cut and paste from GitHub page on Ash's fork into an empty file in vi. Needed to chmod the file I had created using vi to make it executable. Ran in a temp folder (not in SIRF structure). md5 thing seems OK, then fails due to folder structure not as expected:

(base) davidatkinson@eduroam-int-dhcp-97-4-186 temp % ./download_MR_data.sh
Destination is "/Users/davidatkinson/data"
Download location is "/Users/davidatkinson/data"
Downloading MR data
~/data ~/temp
Downloading MR data
curl -L -o PTB_ACRPhantom_GRAPPA.zip https://zenodo.org/record/2633785/files/PTB_ACRPhantom_GRAPPA.zip
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 6251k  100 6251k    0     0  4850k      0  0:00:01  0:00:01 --:--:-- 4850k
Downloaded file's md5sum is ok
~/temp
~/data/MR ~/temp
Unpacking PTB_ACRPhantom_GRAPPA.zip
Archive:  /Users/davidatkinson/data/PTB_ACRPhantom_GRAPPA.zip
   creating: PTB_ACRPhantom_GRAPPA/
  inflating: PTB_ACRPhantom_GRAPPA/ptb_resolutionphantom_fully_ismrmrd.h5  
  inflating: PTB_ACRPhantom_GRAPPA/ptb_resolutionphantom_GRAPPA2_ismrmrd.h5  
  inflating: PTB_ACRPhantom_GRAPPA/ptb_resolutionphantom_GRAPPA4_ismrmrd.h5  
  inflating: PTB_ACRPhantom_GRAPPA/README.txt  
~/temp
creating data_path.py in /Users/davidatkinson/lib/sirf_exercises/data_path.py
/Users/davidatkinson/temp/download_data.sh: line 233: /Users/davidatkinson/lib/sirf_exercises/data_path.py: No such file or directory
some error occured. Retry
ashgillman commented 3 years ago

Great! The error is because it expects /.../lib/sirf_exercises to exist, but you've just run from home so of course it won't :)

KrisThielemans commented 3 years ago

ready to merge then?

ashgillman commented 3 years ago

I believe so. I haven't re-run with your changes from which to command. I /might/ get a chance later tonight