search

SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
17 stars 21 forks source link

SPECT and synergistic PET/SPECT fixes #173

Closed samdporter closed 2 years ago

samdporter commented 2 years ago

Synergistic & SPECT SIRF Exercises updated.
nbstripout run on Synergistic, SPECT & Geometry notebooks

DANAJK commented 2 years ago

I definitely manually deleted locally the "id" lines from Geometry notebooks a b and c_ Now I see there is a new "id" tag in the files that are on Git master and in this pull request Not sure how they got there - perhaps inserted by nbstripout???

samdporter commented 2 years ago

Yeah me and Kris were having trouble making nbstripout run on all my notebooks so did nbstripout *nb I wasn't sure how to revert these changes and thought they might be useful. Shall I get rid of them?

DANAJK commented 2 years ago

Yeah me and Kris were having trouble making nbstripout run on all my notebooks so did nbstripout *nb I wasn't sure how to revert these changes and thought they might be useful. Shall I get rid of them?

I don't think you have put the "id" in my notebooks, I suspect that somehow I either never got rid of them, or git re-inserted something when I committed/pushed.

KrisThielemans commented 2 years ago

not sure what happened here but @samdporter PR should not modify Geometry files of course. (I certainly didn't)

DANAJK commented 2 years ago

not sure what happened here but @samdporter PR should not modify Geometry files of course. (I certainly didn't)

not sure what happened here but @samdporter PR should not modify Geometry files of course. (I certainly didn't)

I think Sam's PR just changed some other little bit of text in the nb, not the "id" part?

samdporter commented 2 years ago

Got rid of my changes. Sorry about that