search

SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
17 stars 21 forks source link

Zenodo saved trained model and results #185

Closed Imraj-Singh closed 1 year ago

Imraj-Singh commented 1 year ago

downloading from zenodo although there are no check to see if the file downloaded correctly. Could add this to the download_data.sh script instead?

danieldeidda commented 1 year ago

Thanks! is this ready to be merged?

KrisThielemans commented 1 year ago

not sure, but I think there's some extra stuff here because you don't have nbstripout installed. @Imraj-Singh can you manually run it and see if it makes any difference?

Imraj-Singh commented 1 year ago

Hi @KrisThielemans, I did install it prior to adding, commiting and pushing that changed notebook. I ran nbstripout 4_setup_training.ipynb. I reran nbstripout 4_setup_training.ipynb, git added and it does not seem like it made a difference. Is there anything else I can do?

KrisThielemans commented 1 year ago

I'll merge it. @samdporter can then complain later :-)