search

SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
18 stars 21 forks source link

Adding extensions, moving postCreateCommand to .sh file, and removing dockerfile #207

Closed Imraj-Singh closed 1 year ago

Imraj-Singh commented 1 year ago

So I tested this by running notebooks/PET/reconstruct_measured_data.ipynb. It did work and I made sure to run in VScode selecting the conda python kernel. Not sure if there is away of pre-configuring the kernel, this seems related.

I found that there was an error when running scripts/download_data.sh: ‘\r’: command not found. So in .devcontainer/postCreateCommand.sh I included the line sed -i 's/\r$//' /workspaces/SIRF-Exercises/scripts/download_data.sh. I am not too sure the reason for this. I am cloning to my native Windows computer and then spinning this up through my WSL? The fix was taken from: here.

KrisThielemans commented 1 year ago

Not sure if there is away of pre-configuring the kernel,

no idea, and I don't think this should sit in the devcontainer anyway, as it shouldn't depend on your local installation.

I found that there was an error when running scripts/download_data.sh: ‘\r’: command not found.

See #208. Please add .gitattributes, remove your sed lines, and see what happens. Otherwise this looks good.

KrisThielemans commented 1 year ago

Please add .gitattributes, remove your sed lines, and see what happens. Otherwise this looks good.

I'll do this myself

Imraj-Singh commented 1 year ago

Please add .gitattributes, remove your sed lines, and see what happens. Otherwise this looks good.

I'll do this myself

@KrisThielemans thank you!