search

SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
18 stars 21 forks source link

Psmr24 pet introductory #227

Closed NicoleJurjew closed 4 months ago

NicoleJurjew commented 4 months ago

Added solutions to a few notebooks and changed some wording

KrisThielemans commented 4 months ago

@NicoleJurjew don't forget to add your name (and others) to the notebooks where you make large changes, or provide the solutions.

NicoleJurjew commented 4 months ago

Hey Kris, this should be ready to go now! I definitely ran nbstripout, I believe creating a "new cell" still look awful when committed. There seems to be a bug though, as VSCode removes and then immediately re-adds files right after running nbstripout, so sorry. Let me know if I should add anything else. Thanks!

KrisThielemans commented 4 months ago

I'll merge this. Please create a new PR with extra authors if appropriate.

danieldeidda commented 4 months ago

great! Some small typos, and a few clone() which shouldn't be necessary. Try to "batch" suggestions that you want to accept (which can be done from the Files tab i think).

Are you sure you ran nbstripout on this?

BTW I also run nbstripout but I can see that id and version (python) are not removed