search

SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
18 stars 21 forks source link

fully_sampled_recon_three_chains fails #31

Closed KrisThielemans closed 3 years ago

KrisThielemans commented 5 years ago

Same problem as https://github.com/CCPPETMR/SIRF/issues/293

KrisThielemans commented 5 years ago

Fixing the ExtractGadget is going to be hard. I suggest we comment it out and do instead

import numpy as np
import sirf.Utiltities
...
real_image_array=np.abs(complex_image_data.as_array())
sirf.Utilities.show_3D_array(real_image_array)
evgueni-ovtchinnikov commented 5 years ago

Found bugs in ExtractGadget, created Gadgetron issue #743.

I feel the workaround applied was not a good idea - we no longer have three chains, so the name of the demo is confusing, and the single chain demo is still affected by one of the bugs (the first one in #743) anyway.

KrisThielemans commented 3 years ago

@evgueni-ovtchinnikov is this still relevant? We need to either fix this, or move the broken notebook(s) to a subfolder with a name broken or similar.

evgueni-ovtchinnikov commented 3 years ago

the notebook is actually ok except that it now should be called fully_sampled_recon_two_chains

KrisThielemans commented 3 years ago

great. Please "git mv" and adjust a README (if any), and close this issue then.

KrisThielemans commented 3 years ago

I've checked that it runs. I'm not sure about the naming, and it's fairly obsolete as a notebook anyway, so I'll just close this.