SyneRBI / SIRF-Exercises

SIRF Training and demonstration material
http://www.ccpsynerbi.ac.uk
Apache License 2.0
18 stars 21 forks source link

requirements.txt does it need to have --only-binary #97

Closed paskino closed 1 year ago

paskino commented 3 years ago

--only-binary in requirements.txt confuses the docker build

Do we need that?

KrisThielemans commented 3 years ago

--only-binary in requirements.txt confuses the docker build

yes, that first fails as conda doesn't have that option, but then pip picks it up, so I didn't bother fixing it when I saw this. Still, better to do it properly.

Do we need that?

I think we can remove it. see https://github.com/SyneRBI/SIRF-Exercises/issues/91#issuecomment-849349791 and comments above and below..

probably also occurs in SIRF.

ashgillman commented 3 years ago

I was unable to install without --only-binary=llvmlite when experimenting recently - we just have to make sure that build dependencies are installed on the VM/Docker.

KrisThielemans commented 3 years ago

yes, but were you able to install with just llvmlite (or possibly you didn't try)

ashgillman commented 3 years ago

Okay, I tested locally and I don't need the --only-binary, but I did previously on the VM - how best to test with docker though?

KrisThielemans commented 3 years ago

once a service image is up, you can

docker exec -ti sirf /bin/bash

and you'll be in as root#, so you can do

sudo -u jovyan
cd /opt/SIRF-Exercises
sed -e 's/--only-binary=[^ ]*//' requirements.txt > ~/test2.txt
conda install --file ~/test2.txt

(still a bit awkward for permissions. No need for /opt/SIRF-Exercises to be owned by sirfuser, which I still need to change.)

Sadly, it then comes back with

PackagesNotFoundError: The following packages are not available from current channels:
  - brainweb[version='>=1.5.1']

It appears that this makes the whole conda install ab?ort, so the Docker script will fall back on pip anyway.

Seems we can just as well leave this alone for now

KrisThielemans commented 1 year ago

Removed in #187