Open KrisThielemans opened 4 years ago
for consistency, I think we should rename DISABLE_GIT_CHECKOUT_SIRF to SIRF_DISABLE_GIT_CHECKOUT.
DISABLE_GIT_CHECKOUT_SIRF
SIRF_DISABLE_GIT_CHECKOUT
I guess we could keep the old variable if people think it's required (but at expense of complexity)
@rijobro ?
hmmm. BUILD_TESTING_SIRF as well...
BUILD_TESTING_SIRF
Isn't it that we use consistently DISABLE_GIT_CHECKOUT_${proj} for all the dependencies? I'd close this issue.
DISABLE_GIT_CHECKOUT_${proj}
https://github.com/SyneRBI/SIRF-SuperBuild/blob/ec4b9c50bb650101e232590405c06eaf417256a6/CMake/SetGitTagAndRepo.cmake#L37
for consistency, I think we should rename
DISABLE_GIT_CHECKOUT_SIRF
toSIRF_DISABLE_GIT_CHECKOUT
.I guess we could keep the old variable if people think it's required (but at expense of complexity)
@rijobro ?