SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 17 forks source link

DISABLE_GIT_CHECKOUT_SIRF or SIRF_DISABLE_GIT_CHECKOUT #325

Open KrisThielemans opened 4 years ago

KrisThielemans commented 4 years ago

for consistency, I think we should rename DISABLE_GIT_CHECKOUT_SIRF to SIRF_DISABLE_GIT_CHECKOUT.

I guess we could keep the old variable if people think it's required (but at expense of complexity)

@rijobro ?

KrisThielemans commented 4 years ago

hmmm. BUILD_TESTING_SIRF as well...

paskino commented 2 years ago

Isn't it that we use consistently DISABLE_GIT_CHECKOUT_${proj} for all the dependencies? I'd close this issue.

https://github.com/SyneRBI/SIRF-SuperBuild/blob/ec4b9c50bb650101e232590405c06eaf417256a6/CMake/SetGitTagAndRepo.cmake#L37