SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild

http://www.ccpsynerbi.ac.uk

Apache License 2.0

15 stars 17 forks source link

override CMAKE_CXX_FLAGS for Boost can cause problems #455

Open KrisThielemans opened 3 years ago

KrisThielemans commented 3 years ago

429 attempted to resolve #161 as follows

https://github.com/SyneRBI/SIRF-SuperBuild/blob/a339f17e7580307aa8394e9c164f4f610462914a/SuperBuild/External_Boost.cmake#L116-L117 However, this means that any "default" compiler flags are removed. This is problematic for Visual Studio as it removed the /EHsc flag, causing problems with exceptions, see https://github.com/SyneRBI/SIRF-SuperBuild/issues/197#issuecomment-749787635

It could of course cause problems elsewhere as well.

KrisThielemans commented 3 years ago

https://github.com/SyneRBI/SIRF-SuperBuild/commit/75281a521e23a185ea90d4bb5b637cb966381278 disabled these lines if (WIN32) such that we don't have this problem with Visual Studio anymore, but this is going to bite us at some point with another compiler. We should check if the original problem persists with recent boost, and if not disable the work-around accordingly