Closed KrisThielemans closed 1 year ago
The JupyterHub uses jupyterlab. https://github.com/SyneRBI/SIRF-Exercises/pull/189 modifies the files accordingly. A few places where we still use the old one:
https://github.com/SyneRBI/SIRF-SuperBuild/blob/3c01b373ebb2f7968f93a0ca101c8503f2140f50/docker/service.sh#L61-L62 https://github.com/SyneRBI/SIRF-SuperBuild/blob/91f4f72d19ec68e1efa127e5fc916a531ec2b416/docker/service.multi.sh#L27 https://github.com/SyneRBI/SIRF-SuperBuild/blob/413ff52f309bdcd669e0c27f9c748dde2c71131d/VirtualBox/Using_VM_as_server.md?plain=1#L26 https://github.com/SyneRBI/SIRF-SuperBuild/blob/8dbc041c4ef6dec2255166b665b992f7b699555d/VirtualBox/documentation/Getting-started-with-SIRF.md#L55
I haven't checked if jupyter lab works on the new VM, but it does on one that I created ~2 months ago, so we should be fine. @evgueni-ovtchinnikov can you check?
jupyter lab
The docker instance would have to be tested.
The JupyterHub uses jupyterlab. https://github.com/SyneRBI/SIRF-Exercises/pull/189 modifies the files accordingly. A few places where we still use the old one:
https://github.com/SyneRBI/SIRF-SuperBuild/blob/3c01b373ebb2f7968f93a0ca101c8503f2140f50/docker/service.sh#L61-L62 https://github.com/SyneRBI/SIRF-SuperBuild/blob/91f4f72d19ec68e1efa127e5fc916a531ec2b416/docker/service.multi.sh#L27 https://github.com/SyneRBI/SIRF-SuperBuild/blob/413ff52f309bdcd669e0c27f9c748dde2c71131d/VirtualBox/Using_VM_as_server.md?plain=1#L26 https://github.com/SyneRBI/SIRF-SuperBuild/blob/8dbc041c4ef6dec2255166b665b992f7b699555d/VirtualBox/documentation/Getting-started-with-SIRF.md#L55
I haven't checked if
jupyter labworks on the new VM, but it does on one that I created ~2 months ago, so we should be fine. @evgueni-ovtchinnikov can you check?The docker instance would have to be tested.