search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 18 forks source link

have to use USE_SYSTEM_HDF=OFF on docker #808

Closed KrisThielemans closed 8 months ago

KrisThielemans commented 1 year ago

@paskino saw this when releasing SIRF 3.4. My diagnosis is at https://github.com/SyneRBI/SIRF-SuperBuild/pull/787#issuecomment-1379254824 and essentially says the system hdf5 on Ubuntu doesn't come with the cmake export files (why? Who knows) and you need to install h5cc to get it to work, which implies installing hdf5-helpers.

However, Edo tried this and said it didn't work https://github.com/SyneRBI/SIRF-SuperBuild/pull/787#issuecomment-1381986403 so he gave up and set USE_SYSTEM_HDF5=OFF https://github.com/SyneRBI/SIRF-SuperBuild/blob/79cc17a0b11228a3cb40951434e8d9643824735d/docker/Dockerfile#L139.

If we build HDF5 ourselves, then the cmake export files are there, and everything works fine. This isn't great of course as it adds to our building time and docker size etc.

I haven't investigated further why installing hdf5-helpers didn't work on docker.

KrisThielemans commented 1 year ago

even though hdf5-helpers, https://github.com/SyneRBI/SIRF-SuperBuild/actions/runs/3910975235/jobs/6684605562#step:7:11805 still says

HDF5 C compiler wrapper is unable to compile a minimal HDF5 program.

Easiest probably to download a docker image and see what h5cc says.

KrisThielemans commented 8 months ago

Let's try this, if it doesn't work, let's not fix this for this release