search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 17 forks source link

use environment.yml from SIRF-Exercise #821

Closed paskino closed 11 months ago

paskino commented 11 months ago

Uses environment.yml from SIRF-Exercises if using conda, and it is found. Defaults to requirements.txt if not found or not using conda.

closes #814

paskino commented 11 months ago

Yes, I think it's because of CIL and numpy: CIL is currently available as binaries up to numpy 1.23 and apparently the SuperBuild initially installs 1.24.

Notice that CIL follows the NEP-29 for the numpy version supported.

KrisThielemans commented 11 months ago

apparently the SuperBuild initially installs 1.24.

"the SuperBuild" = "the requirements files in this directory" of course. This will need to be cleaned-up for the next version.

Note https://github.com/SyneRBI/SIRF-SuperBuild/blob/a78c64d11a51f4a757cf3758a290c17c84ffcb6a/docker/requirements.yml#L13-L14 the scipy restrictions seems very out of date, and is in any case overriden by the SIRF-exercises (see above).

Can you please create an issue for the next release for sorting this out?