search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 17 forks source link

Update version_config.cmake and others files for release #829

Closed paskino closed 10 months ago

paskino commented 11 months ago

updates for release 3.5.0

KrisThielemans commented 11 months ago

more CCPi regulariser trouble sadly

    from ccpi.filters.regularisers import ROF_TV, FGP_TV, PD_TV, SB_TV, TGV, LLT_ROF, FGP_dTV, NDF, Diff4th
  File "/home/runner/install/python/ccpi/filters/regularisers.py", line 5, in <module>
    from ccpi.filters.cpu_regularisers import TV_ROF_CPU, TV_FGP_CPU, TV_PD_CPU, TV_SB_CPU, dTV_FGP_CPU, TNV_CPU, NDF_CPU, Diff4th_CPU, TGV_CPU, LLT_ROF_CPU, PATCHSEL_CPU, NLTV_CPU
ImportError: /home/runner/install/python/ccpi/filters/cpu_regularisers.cpython-310-x86_64-linux-gnu.so: undefined symbol: _Z14SB_TV_CPU_mainPfS_S_fifiiii

Docker builds still stuck due to #826

paskino commented 11 months ago

I'm not sure where this bug comes from, it used to work earlier and I am tempted to remove the unit tests for the release and open an issue for next release.

I opened an issue on the https://github.com/vais-ral/CCPi-Regularisation-Toolkit/issues/177 repo.

paskino commented 10 months ago

@KrisThielemans @evgueni-ovtchinnikov @casperdcl now that the tests are all green (see https://github.com/SyneRBI/SIRF-SuperBuild/pull/829/commits/6e0b7e37b57ddf9269af0defc9afa0dc52b07f78), I suggest to merge this PR and tag the SuperBuild. We should then tackle #832 in a later release.

This PR removes the CCPi Regularisation from the packages built with CIL.

KrisThielemans commented 10 months ago

This PR removes the CCPi Regularisation from the packages built with CIL.

why? I thought you were just going to disable the tests. If you need to disable the build, then #832 needs to be adjusted.

I suggest to merge this PR and tag the SuperBuild.

Please merge #830 after this PR. It avoids conflicts for people who have MATLAB installed.

paskino commented 10 months ago

The unit test fails because of an import error. I didn't understand why this happens in the GitHub runner. I thought to outright remove the software instead of packaging it with potential import errors.

KrisThielemans commented 10 months ago

ok