search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 17 forks source link

CCPi regularisation fails test #832

Closed paskino closed 3 weeks ago

paskino commented 10 months ago

CCPi regularisation toolkit builds but unit tests fail with messages as https://github.com/SyneRBI/SIRF-SuperBuild/pull/829#issuecomment-1643646935 or

File "/home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/sources/CCPi-Regularisation-Toolkit/test/test_run_test.py", line 5, in <module>
    from ccpi.filters.regularisers import ROF_TV, FGP_TV, PD_TV, SB_TV, TGV, LLT_ROF, FGP_dTV, NDF, Diff4th
  File "/home/runner/install/python/ccpi/filters/regularisers.py", line 5, in <module>
    from ccpi.filters.cpu_regularisers import TV_ROF_CPU, TV_FGP_CPU, TV_PD_CPU, TV_SB_CPU, dTV_FGP_CPU, TNV_CPU, NDF_CPU, Diff4th_CPU, TGV_CPU, LLT_ROF_CPU, PATCHSEL_CPU, NLTV_CPU
ImportError: /home/runner/install/python/ccpi/filters/cpu_regularisers.cpython-310-x86_64-linux-gnu.so: undefined symbol: _Z14SB_TV_CPU_mainPfS_S_fifiiii
paskino commented 10 months ago

We should reinstate https://github.com/SyneRBI/SIRF-SuperBuild/pull/829/commits/90faebc93f6a67ae19840a344f2cc15a64b563f7 and https://github.com/SyneRBI/SIRF-SuperBuild/pull/829/commits/6e0b7e37b57ddf9269af0defc9afa0dc52b07f78

paskino commented 10 months ago

After #829 the ccpi-regularisation is not built as CIL dependency

casperdcl commented 3 months ago

@paskino I guess you'll push a new toolkit release?

paskino commented 3 months ago

Can we just use a different commit hash

KrisThielemans commented 3 months ago

fine for me