search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 18 forks source link

Check the readme file for out of date information #833

Closed paskino closed 6 months ago

paskino commented 1 year ago

Info on gadgetron config file is old and possibly the one on patching the header files

KrisThielemans commented 1 year ago

@paskino, text says "use Gadgetron master" but that hash is no longer master, I'm sure. Maybe write the date of the version instead.

KrisThielemans commented 1 year ago

oops. I meant in CHANGES.md, not readme

casperdcl commented 11 months ago

Info on gadgetron config file is old and possibly the one on patching the header files

not sure what this means

KrisThielemans commented 11 months ago

patch: https://github.com/SyneRBI/SIRF-SuperBuild/blob/master/README.md#gadgetron-include-patch. I don't think we do this anymore. @paskino?

https://github.com/SyneRBI/SIRF-SuperBuild/blob/master/README.md#example-gadgetron-configuration-file this we definitely don't do anymore. Gadgetron doesn't need this anymore.

KrisThielemans commented 11 months ago

@casperdcl @paskino has this been resolved?

KrisThielemans commented 7 months ago

Moving this to 3.6 such that we don't forget. Probably all resolved, but I haven't checked.