Closed casperdcl closed 4 months ago
Also, for DEVEL_BUILD=ON
, why is siemens_to_ismrmrd
using a very old commit?
suggestion:
- set(DEFAULT_siemens_to_ismrmrd_TAG b87759e49e53dab4939147eb52b7a0e6465f3d04)
+ set(DEFAULT_siemens_to_ismrmrd_TAG origin/master)
suggestion:
- set(DEFAULT_siemens_to_ismrmrd_TAG b87759e49e53dab4939147eb52b7a0e6465f3d04) + set(DEFAULT_siemens_to_ismrmrd_TAG origin/master)
We have had a lot of trouble trying to track the Gadgetron guys in the past. If we do this, we'd also have to track ISMRMRD master etc. There's no reason for us to be so bleeding edge on that front, so I'd prefer to keep DEFAULT and DEVEL tags the same.
Thanks for assigning to me, but I'm afraid I'd rather have someone else taking care of it... @paskino @evgueni-ovtchinnikov ?
We have had a lot of trouble trying to track the Gadgetron guys in the past. If we do this, we'd also have to track ISMRMRD master etc. There's no reason for us to be so bleeding edge on that front, so I'd prefer to keep DEFAULT and DEVEL tags the same.
we already track master
on everything except siemens_to_ismrmrd_TAG
:
should be master of SIRF and STIR only, as those are the only ones we have under control. Or in fact, maybe want to do SIRF only, for STIR have a fixed (but recent) commit.
To fix gadgetron-python support
-- @KrisThielemans in https://github.com/SyneRBI/SIRF-SuperBuild/pull/718#issuecomment-1876579808
so: