search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 18 forks source link

update to ROOT v6-28-12 #859

Closed KrisThielemans closed 7 months ago

KrisThielemans commented 8 months ago

hopefully fixes #857

KrisThielemans commented 8 months ago

v6-28-12 compiled TBB ok, but the failed in XROOTD installation. XROOTD-install-err.log says

[I] No git repository info found. Trying to interpret VERSION_INFO
[I] The XrdVersion.hh file already exists
gmake[7]: *** read jobs pipe: Bad file descriptor.  Stop.
gmake[7]: *** Waiting for unfinished jobs....
gmake[6]: *** [Makefile:136: all] Error 2
CMake Error at /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-Release-impl.cmake:9 (message):
  Command failed (2):

   '/usr/local/bin/cmake' '--build' '.' '--target' 'install'
KrisThielemans commented 7 months ago

Needed more recent `nlohmann/json due to https://github.com/root-project/root/issues/14634

Still stuck due to #861

KrisThielemans commented 7 months ago

Although #857 auto-disappeared (presumably due to a wrong config of the GHA runners), updating ROOT is necessary for C++-17, which will be required for the next STIR version (https://github.com/UCL/STIR/pull/1236 in progress), so best to merge this now.