SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 17 forks source link

VM build fails due to missing docker/requirements-service.txt #882

Closed KrisThielemans closed 3 months ago

KrisThielemans commented 3 months ago

https://github.com/SyneRBI/SIRF-SuperBuild/blob/673969b375bb6d2ae139c168f1be9158baf08d23/VirtualBox/scripts/INSTALL_python_packages.sh#L78 fails as this file no longer exists. It was used to install jupyter etc, see https://github.com/SyneRBI/SIRF-SuperBuild/blob/v3.5.0/docker/requirements-service.txt

@casperdcl you removed it as it was no longer necessary for the docker set-up. It is of course a bit dangerous to hijack docker files for the VM, but that was done to avoid duplication. How do you prefer to handle this? Reinstate it in the same place or in the VB folder?