search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 17 forks source link

Docker README question #888

Closed KrisThielemans closed 3 months ago

KrisThielemans commented 3 months ago

README on "Extending" says

FROM synerbi/sirf:jupyter-gpu

is ghcr.io missing? I have no idea...

casperdcl commented 3 months ago

we tag for both registries https://github.com/SyneRBI/SIRF-SuperBuild/blob/fd4e9720965f846889e468eb938c88e5805ff5d3/.github/workflows/docker.yml#L39-L40 including login creds https://github.com/SyneRBI/SIRF-SuperBuild/blob/fd4e9720965f846889e468eb938c88e5805ff5d3/.github/workflows/docker.yml#L51-L61 and push https://github.com/SyneRBI/SIRF-SuperBuild/blob/fd4e9720965f846889e468eb938c88e5805ff5d3/.github/workflows/docker.yml#L108

so the ghcr.io is optional. I use it explicitly in GHA as it should be quicker due to physical server locations.

KrisThielemans commented 3 months ago

great. thanks!