docker docs - Githubissues

casperdcl commented 3 months ago

fix localhost URL (fixes #889)
fix -gpu suffix
document tags (fixes #890)
- drop :jupyter tag (just use :latest) 5168369 - maybe revert?

casperdcl commented 3 months ago

@KrisThielemans I prefer the last commit here, but up to you if you'd prefer to revert it

KrisThielemans commented 3 months ago

I think this table helps a lot! Thanks. Comments on the table:

I think the row only build & test (no tag) | CI (current commit) is a bit confusing though. Maybe this should be built & tested during CI (no tag) | master ? (maybe it should be in bold?)
The first tag you see at https://github.com/SyneRBI/SIRF-SuperBuild/pkgs/container/sirf is core but it's not in the table, which probably is confusing.

I don't have a strong opinion on latest vs jupyter. I have no idea what conventions people generally use for docker tagging. We had sirf:latest and it's a reasonable name, more so than sirf:jupyter, so I'm fine with keeping latest.

I note that we had sirf:latest and sirf:service. We no longer have the latter, and I think that's fine, as it was a bit confusing. I'm assuming (in fact, I know) that sirf:latest now has the jupyter service running, so we could easily claim that these 2 have been merged into 1. (I do think that this needs to be stated explicitly in CHANGES.md).

I'm still confused though by the last bit of the README, which talks about synerbi/jupyter:sirf images made by copying stuff from sirf:latest. Is that correct? Shouldn't they be in the table then? But they are not pushed?

KrisThielemans commented 3 months ago

synerbi/jupyter:* and synerbi/sirf:core* are simply internal caches, so aren't in the table.

ok. Maybe a line with a clarification then for people like me ? :smile:

I'm fine with your other suggestions.

SyneRBI / SIRF-SuperBuild

docker docs #891