search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 17 forks source link

update CIL and CCPi-Regularisation version and reinstate tests #897

Closed paskino closed 3 weeks ago

paskino commented 1 month ago

Bump CIL and CCPi-Regularisation-Toolkit versions for PSMR24 training school

Currently failing build with BUILD_ROOT=ON . I don't undestand where this comes from as I did not change anything around this.

CMake Error at /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-Release.cmake:49 (message):
  Command failed: 1

   '/usr/local/bin/cmake' '-Dmake=' '-Dconfig=' '-P' '/home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-Release-impl.cmake'
paskino commented 1 month ago

@KrisThielemans do you have any clue onto why ROOT fails to build with these changes?

KrisThielemans commented 1 month ago

https://github.com/SyneRBI/SIRF-SuperBuild/actions/runs/9074911667/job/24934505517?pr=897#step:10:10217

[  0%] Performing install step for 'XROOTD'
CMake Error at /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-Release.cmake:49 (message):
  Command failed: 1
   '/usr/local/bin/cmake' '-Dmake=' '-Dconfig=' '-P' '/home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-Release-impl.cmake'
  See also
    /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-*.log

Luckily, we do upload logs as an artefact (visible in the Summary of the Action). Checking the install-err.log:

gmake[7]: *** read jobs pipe: Bad file descriptor.  Stop.
gmake[7]: *** Waiting for unfinished jobs....
gmake[6]: *** [Makefile:136: all] Error 2

We have had this before https://github.com/root-project/root/issues/14520 and it auto-disappeared.

Presumably our build is overload the MS network... Sadly, I'm not sure what can be done about it. I suppose we could modify the job to use a packaged ROOT as opposed to building it ourselves, and have one that does build it, but is allowed to fail.

KrisThielemans commented 1 month ago

Here's what we do in STIR GHA https://github.com/UCL/STIR/blob/feb6d85eadb392f5b8278d3b97ae2ee67ca439d9/.github/workflows/build-test.yml#L260-L264 You'd then have to say USE_SYSTEM_ROOT=ON. Of course, it would make sense to put the download in the docker scripts. Not 100% sure about the source .../thisroot.sh though.

paskino commented 1 month ago

Does this mean we will not test BUILD_ROOT=ON rather USE_SYSTEM_ROOT=ON on the CI?

KrisThielemans commented 1 month ago

yes, I think it'd be nice to have one job where we build it ourselves, but allow failure, as I wrote.

KrisThielemans commented 1 month ago

Please merge master to get the correct STIR version.

KrisThielemans commented 1 month ago

@paskino @casperdcl this is ready to merge from my perspective. Please ahead, and then tag.

casperdcl commented 1 month ago

IIRC @paskino found another bug in this PR

paskino commented 3 weeks ago

waiting for

KrisThielemans commented 3 weeks ago

@casperdcl @paskino please merge and tag

casperdcl commented 3 weeks ago
srry nvm, was looking at wrong logs Still some failing tests @paskino ... gcc-9: ```py ====================================================================== ERROR: test_TVdenoisingMR (test_SIRF.TestGradientMR_2D) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/sources/CIL/Wrappers/Python/test/test_SIRF.py", line 263, in test_TVdenoisingMR fista.run(verbose=0) File "/home/runner/install/python/cil/optimisation/algorithms/Algorithm.py", line 240, in run for _ in zip(range(self.iteration, self.iteration + iterations), self): File "/home/runner/install/python/cil/optimisation/algorithms/Algorithm.py", line 108, in __next__ self.update() File "/home/runner/install/python/cil/optimisation/algorithms/FISTA.py", line 295, in update self.f.gradient(self.y, out=self.x) File "/home/runner/install/python/cil/optimisation/functions/Function.py", line 480, in gradient res *= self.scalar TypeError: unsupported operand type(s) for *=: 'NoneType' and 'float' ---------------------------------------------------------------------- ====================================================================== ERROR: test_CPU_regularisers (unittest.loader._FailedTest) ---------------------------------------------------------------------- ImportError: Failed to import test module: test_CPU_regularisers Traceback (most recent call last): File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/unittest/loader.py", line 436, in _find_test_path module = self._get_module_from_name(name) File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/unittest/loader.py", line 377, in _get_module_from_name __import__(name) File "/home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/sources/CCPi-Regularisation-Toolkit/test/test_CPU_regularisers.py", line 6, in from ccpi.filters.regularisers import FGP_TV, SB_TV, TGV, LLT_ROF, FGP_dTV, NDF, Diff4th, ROF_TV, PD_TV Errors while running CTest ModuleNotFoundError: No module named 'ccpi' ``` gcc-11: ``` -- XROOTD build command succeeded. See also /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-build-*.log [ 0%] Performing install step for 'XROOTD' CMake Error at /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-Release.cmake:49 (message): Command failed: 1 '/usr/local/bin/cmake' '-Dmake=' '-Dconfig=' '-P' '/home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-Release-impl.cmake' See also /home/runner/work/SIRF-SuperBuild/SIRF-SuperBuild/build/builds/ROOT/build/builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install-*.log gmake[5]: *** [builtins/xrootd/CMakeFiles/XROOTD.dir/build.make:104: builtins/xrootd/XROOTD-prefix/src/XROOTD-stamp/XROOTD-install] Error 1 gmake[4]: *** [CMakeFiles/Makefile2:9131: builtins/xrootd/CMakeFiles/XROOTD.dir/all] Error 2 gmake[3]: *** [Makefile:156: all] Error 2 gmake[2]: *** [CMakeFiles/ROOT.dir/build.make:86: builds/ROOT/stamp/ROOT-build] Error 2 gmake[1]: *** [CMakeFiles/Makefile2:590: CMakeFiles/ROOT.dir/all] Error 2 ```