Update CI to allow failure on `BUILD_ROOT=ON`

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild

http://www.ccpsynerbi.ac.uk

Apache License 2.0

15 stars 17 forks source link

Update CI to allow failure on `BUILD_ROOT=ON` #898

Closed paskino closed 1 month ago

paskino commented 1 month ago

closes #899

Failures in the build will appear as annotations which can be found at https://github.com/SyneRBI/SIRF-SuperBuild/pull/898/checks or by clicking the checks tab on the PR interface. One needs to spot and click on the little speech balloon with the esclamation mark inside to see the actual errors.

casperdcl commented 1 month ago

actually - I don't see any deployment jobs which depend on the 2 failing tests... So maybe it's ok to leave them failing noisily? /CC @KrisThielemans

KrisThielemans commented 1 month ago

I don't think we can have hinds falling regularly. But it's not great to have a lot of jobs falling silently either. So, I go back to my suggestion to install ROOT in another way for most jobs. Possibly, this is already done for the docker builds.

KrisThielemans commented 1 month ago

I'm going to close this now that we have #901 merged, but mention it in a new issue.