search

SyneRBI / SIRF-SuperBuild

SIRF CMake SuperBuild
http://www.ccpsynerbi.ac.uk
Apache License 2.0
15 stars 17 forks source link

update parallelproj to 1.9.0 (and require it), as well as CIL, SIRF, STIR #906

Closed KrisThielemans closed 1 week ago

KrisThielemans commented 2 weeks ago

See https://github.com/gschramm/parallelproj/issues/69

KrisThielemans commented 1 week ago

Failures due to issues unrelated to this PR: https://github.com/SyneRBI/SIRF/issues/1267 https://github.com/TomographicImaging/CIL/issues/1837 https://github.com/TomographicImaging/CIL/issues/1838

KrisThielemans commented 1 week ago

We need to update SIRF and CIL for numpy 2.0 issues. Can just as well do STIR.

KrisThielemans commented 1 week ago

2 problems resolved, but CIL_FRAMEWORK_TESTS_6 still fails due to https://github.com/TomographicImaging/CIL/issues/1838

KrisThielemans commented 1 week ago

Some failures due to Zenodo time-out. Docker jobs

ERROR: test_SIRF (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_SIRF
Traceback (most recent call last):
  File "/opt/conda/lib/python3.10/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/conda/lib/python3.10/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/jovyan/cil_sirf_test/test_SIRF.py", line 29, in <module>
    from cil.optimisation.utilities import AdaptiveSensitivity
ImportError: cannot import name 'AdaptiveSensitivity' from 'cil.optimisation.utilities' (/opt/conda/lib/python3.10/site-packages/cil/optimisation/utilities/__init__.py)

not sure if this is the most recent though.

KrisThielemans commented 1 week ago

https://github.com/TomographicImaging/CIL/issues/1846

KrisThielemans commented 1 week ago

I'll merge this anyway, as it fixes other problems.