SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
58 stars 29 forks source link

Implemented safer C++ DataContainer data type handling, fixes #1193 #1195

Closed evgueni-ovtchinnikov closed 10 months ago

evgueni-ovtchinnikov commented 1 year ago

Changes in this pull request

Current C++ DataContainer classes use static casts of void* pointers, which may be unsafe (cf. #1193).

This PR implements an alternative template-based design whereby static casts are only used on C interface level, which is not supposed to be used by SIRF users.

Testing performed

Related issues

Fixes #1193

Checklist before requesting a review

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

evgueni-ovtchinnikov commented 10 months ago

Left unattended for a long time, resulting in weird conflicts with master. Taken over by PR #1210.