SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
59 stars 29 forks source link

get_trajectory does not return the trajectory but recalculates it #1205

Open ckolbPTB opened 1 year ago

ckolbPTB commented 1 year ago

We have got the function set_data_trajectory which allows users to set the values of the k-space trajectory.

We also have to function get_data_trajectory which as far as I understand does not return the content of the k-space trajectory but actually recalculates it here

Nikos came across this problem, because he has got spiral acquisitions and he sets the trajectory with set_data_trajectory. When he then calls get_data_trajectory he gets an array of zeros because the calculation of spiral trajectories is not implemented in SIRF.

Should we rename get_data_trajectory to calc_data_trajectory and throw an error if the trajectory is SPIRAL and then implement a proper get_data_trajectory which returns the content of the trajectory?