Avoid using `import *` in Python MR and PET demo scripts - Githubissues

SyneRBI / SIRF

Main repository for the CCP SynerBI software

http://www.ccpsynerbi.ac.uk

Other

59 stars 29 forks source link

Avoid using `import *` in Python MR and PET demo scripts #1215

Closed evgueni-ovtchinnikov closed 11 months ago

evgueni-ovtchinnikov commented 11 months ago

Changes in this pull request

Currently, we use

exec('from sirf.' + args['--engine'] + ' import *')

to import reconstruction modules (engines) for MR (Gadgetron) and PET (STIR). This practice is not recommended, and raises Codacy complaints.

This PR suggests using importlib function instead, e.g. for MR:

import importlib
mr = importlib.import_module('sirf.' + args['--engine'])
acq_data = mr.AcquisitionData()

Testing performed

The demo scripts run ok on my VM.

Related issues

Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have added docstrings/doxygen in line with the guidance in the developer guide
[ ] I have implemented unit tests that cover any new or modified functionality
[x] The code builds and runs on my machine
[x] CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

[x] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

KrisThielemans commented 11 months ago

great idea.