SyneRBI / SIRF

Main repository for the CCP SynerBI software
http://www.ccpsynerbi.ac.uk
Other
59 stars 29 forks source link

MR AcquisitionData dimensions can be undefined #1220

Closed ckolbPTB closed 10 months ago

ckolbPTB commented 10 months ago

In several functions e.g. https://github.com/SyneRBI/SIRF/blob/6c7e3d778e23c85ea3a719c2e2668d4c38e1fde0/src/xGadgetron/cGadgetron/gadgetron_data_containers.cpp#L193

https://github.com/SyneRBI/SIRF/blob/6c7e3d778e23c85ea3a719c2e2668d4c38e1fde0/src/xGadgetron/cGadgetron/gadgetron_data_containers.cpp#L223

https://github.com/SyneRBI/SIRF/blob/6c7e3d778e23c85ea3a719c2e2668d4c38e1fde0/src/xGadgetron/cGadgetron/gadgetron_data_containers.cpp#L243

we are looping through all acquisitions to get some information about dimensions.

If get_acquisition() returns False for all acquisitions then the dimensions are undefined. We should make sure that all the dimensions are intialised with 0 and/or throw an error.